mcpx: CI lint leg (vet, golangci-lint, gofmt, shellcheck, actionlint) + plugin bun test leg (#1996) by dezren39 · Pull Request #2718 · developing-today/code

dezren39 · 2026-10-30T11:44:48Z

What

First implementation slice of #1996, rescoped against current main. mcpx CI had no lint step and the plugin's bun test suite had never run in CI.

pkgs/mcpx/.golangci.yml (new): golangci-lint v2 config — linters.default: standard plus staticcheck with checks: [all]. Not default: all, not gosec-blocking.
.github/workflows/mcpx.yml: new lint leg running go vet ./..., golangci-lint run, a gofmt -l check, shellcheck over pkgs/mcpx/scripts (root .shellcheckrc, enable=all) and actionlint; plus a plugin leg running bun test over every pkgs/mcpx/plugin/opencode/mcpx/*.test.ts (daemon, ceiling, ops — the set grew since mcpx testing: every formatter and linter in the CI matrix, pinned by the flake (and run the plugin's bun test) #1996 was written).
nix-common.nix: tool versions pinned through the flake/dev shell rather than per-action version inputs (approach C).
Findings fixed in the same PR: the shellcheck baseline (SC2034/SC2319 in scripts/stress.sh, SC2012 in bench.sh) and the Go vet/staticcheck findings the new leg surfaces. Baseline was small; gofmt was already clean.

Verification

GitHub Actions, this PR: the new lint leg and plugin (bun test) leg.
Existing go test ./... legs and the mcpx-nixbuild workflow must stay green.

No sandbox builds — CI is the verification surface.

Scope

This does not close #1996. Remaining steps there (TS lint/check, per-language formatting enforcement) are later slices.

Queue task 3291.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

…plugin bun test (#1996) The mcpx workflow ran no lint and never ran the plugin's tests. This adds the first slice of #1996: - pkgs/mcpx/.golangci.yml: v2 config, default: standard, staticcheck with checks: all. Not default: all (gosec and the rest are not blocking here). - mcpx.yml `lint` job: go vet, golangci-lint run, gofmt -l (must be empty), shellcheck over pkgs/mcpx/scripts, actionlint. The tools come from the dev shell (`nix develop`), so flake.lock pins them and the workflow passes no per-action version input (Approach C); golangci-lint and actionlint are added to nix-common.nix devTools beside mcpx. - mcpx.yml `plugin` job: bun test over every pkgs/mcpx/plugin/opencode/mcpx/*.test.ts file (the set grew past the daemon.test.ts #1996 named). Ops tests skip without OPS_LIVE_SOCKET; the Go job is where the daemon itself is exercised. Findings fixed in the same PR: 12 files were not gofmt-clean on main, and stress.sh had SC2034 (unused `here`) and SC2319 (`check $?` after `[ ]`). TS lint/check and per-language formatting enforcement stay on #1996. Refs #1996 Co-authored-by: CommandCodeBot <noreply@commandcode.ai>

coderabbitai · 2026-10-30T11:44:57Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c82e3fa9-bf3c-49c9-8f2a-79e5811245fa

Commits

Reviewing files that changed from the base of the PR and between 8808dfa and f8653b4.

Files selected for processing: 16

.github/workflows/mcpx.yml
lib/default.nix
nix-common.nix
pkgs/mcpx/.golangci.yml
pkgs/mcpx/internal/catalog/embeddings.go
pkgs/mcpx/internal/codegen/codegen_test.go
pkgs/mcpx/internal/config/config_test.go
pkgs/mcpx/internal/daemon/registry.go
pkgs/mcpx/internal/daemon/routes_consumer_test.go
pkgs/mcpx/internal/logstore/feedback.go
pkgs/mcpx/internal/mcpserver/reactive.go
pkgs/mcpx/internal/mcpserver/skills.go
pkgs/mcpx/internal/scripting/provider.go
pkgs/mcpx/internal/scripting/scripting_test.go
pkgs/mcpx/internal/testsupport/quarantine_test.go
pkgs/mcpx/scripts/stress.sh

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-30T11:44:59Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T22:03:56.779507Z	`777620d`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>

…ller extra-conf, #1996)

The lint job realised the flake default dev shell (whole monorepo env: Rust, Android SDK, clan, Haskell) on a cold runner and was cancelled at its 20-minute timeout before any linter ran (run 41122626395). Add a minimal devShells.mcpx-lint (go_1_27, golangci-lint, shellcheck, actionlint from the same pinned nixpkgs-unstable) and point the lint leg at it; tool versions stay flake-pinned (Approach C).

First full golangci run surfaced 119 pre-existing findings module-wide (errcheck 50, staticcheck 50, unused 17, ineffassign 2) — filed as #2836 per #1996 acceptance fallback. vet/gofmt/shellcheck/actionlint stay blocking; golangci prints every run but does not gate until #2836 removes continue-on-error.

…nt-plugin-tests

… doc comment (#1996)

…lcheck -S warning (#1996)

dezren39 requested a review from a team as a code owner October 30, 2026 11:44

Merge origin/main into queue/3291-1996-ci-lint-plugin-tests

659f60b

Co-authored-by: CommandCodeBot <noreply@commandcode.ai>

This was referenced Oct 30, 2026

mcpx testing: every formatter and linter in the CI matrix, pinned by the flake (and run the plugin's bun test) #1996

Closed

mcpx testing: first CI iteration -- unit + e2e shards + lint + nix build, and a recorded baseline #1998

Closed

github-actions Bot assigned dezren39 Oct 30, 2026

dezren39 added 3 commits October 30, 2026 15:13

ci(mcpx): enable cgroups feature for the lint leg dev shell (#1996)

20e8c12

ci(mcpx): enable cgroups in the daemon config for the lint leg (insta…

c724bd7

…ller extra-conf, #1996)

dezren39 mentioned this pull request Oct 30, 2026

mcpx: fix the 119 golangci findings the new lint leg surfaced, then make the leg blocking #2836

Open

3 tasks

dezren39 added 4 commits October 30, 2026 16:35

Merge remote-tracking branch 'origin/main' into queue/3291-1996-ci-li…

07f5c64

…nt-plugin-tests

style(mcpx): gofmt testsupport/quarantine_test.go — blank line before…

777620d

… doc comment (#1996)

ci(mcpx): scope the lint leg actionlint to the mcpx workflows at shel…

f8653b4

…lcheck -S warning (#1996)

dezren39 mentioned this pull request Oct 30, 2026

actionlint: repo-wide findings outside the mcpx workflow set (jules concurrency.queue, SC2129, SC2016/SC2086 in run blocks) #2845

Closed

4 tasks

dezren39 merged commit 0005072 into main Oct 30, 2026
11 checks passed

dezren39 deleted the queue/3291-1996-ci-lint-plugin-tests branch October 30, 2026 22:37

dezren39 mentioned this pull request Oct 31, 2026

ci(mcpx): first measured iteration — static e2e shards + unit + lint + ci-ok (#1998) #2888

Merged

dezren39 restored the queue/3291-1996-ci-lint-plugin-tests branch November 1, 2026 09:06

dezren39 deleted the queue/3291-1996-ci-lint-plugin-tests branch November 1, 2026 16:45

Navigation Menu

Repository navigation

mcpx: CI lint leg (vet, golangci-lint, gofmt, shellcheck, actionlint) + plugin bun test leg (#1996) - #2718

mcpx: CI lint leg (vet, golangci-lint, gofmt, shellcheck, actionlint) + plugin bun test leg (#1996)#2718
dezren39 merged 9 commits into
mainfrom
queue/3291-1996-ci-lint-plugin-tests

dezren39 commented Oct 30, 2026 •

edited by blacksmith-sh Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dezren39 commented Oct 30, 2026 • edited by blacksmith-sh Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Verification

Scope

Uh oh!

coderabbitai Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dezren39 commented Oct 30, 2026 •

edited by blacksmith-sh Bot

Loading

coderabbitai Bot commented Oct 30, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 30, 2026 •

edited

Loading